Issue 374223002: Pepper: Fix permissions for PNaCl plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374223002: Pepper: Fix permissions for PNaCl plugins. (Closed)

Created:
6 years, 5 months ago by teravest

Modified:
6 years, 5 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Fix permissions for PNaCl plugins. A change to enable whitelisting for some applications incorrectly determined whether or not the module being loaded was "llc" or "ld". This resulted in a few regressions: * PNaCl applications can't use dev channel APIs * PNaCl applications see no effect with --enable-pepper-testing. This change checks the correct field in NaClLaunchParams instead. BUG=392277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281949

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	components/nacl/browser/nacl_host_message_filter.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/374223002/1

6 years, 5 months ago (2014-07-08 22:38:24 UTC) #5

Message was sent while issue was closed.

Change committed as 281949

Expand Messages | Collapse Messages