Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: components/nacl/browser/nacl_host_message_filter.cc

Issue 374223002: Pepper: Fix permissions for PNaCl plugins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/browser/nacl_host_message_filter.cc
diff --git a/components/nacl/browser/nacl_host_message_filter.cc b/components/nacl/browser/nacl_host_message_filter.cc
index 7dfa782e234869310182097854b67ad7f824dc95..0b35afc93f081959336f87c315750fefd1d53cc4 100644
--- a/components/nacl/browser/nacl_host_message_filter.cc
+++ b/components/nacl/browser/nacl_host_message_filter.cc
@@ -117,8 +117,10 @@ net::HostResolver* NaClHostMessageFilter::GetHostResolver() {
void NaClHostMessageFilter::OnLaunchNaCl(
const nacl::NaClLaunchParams& launch_params,
IPC::Message* reply_msg) {
- // PNaCl hack
- if (!launch_params.enable_dyncode_syscalls) {
+ // If we're running llc or ld for the PNaCl translator, we don't need to look
+ // up permissions, and we don't have the right browser state to look up some
+ // of the whitelisting parameters anyway.
+ if (!launch_params.uses_irt) {
uint32 perms = launch_params.permission_bits & ppapi::PERMISSION_DEV;
LaunchNaClContinuation(
launch_params,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698