gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt - Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix window's webgl conformance test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/android_video_decode_accelerator.cc ('k') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

index 4431e4938fa5da651cf56b860f642fe8e72ba2fc..04a1f50cd3c71860aa606c20f274b6d29044a020 100644

--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

@@ -47,7 +47,18 @@ New Procedures and Functions

destination texture. The level parameter must be 0 at present.

The internal format of the destination texture is converted to that

- specified by <internal_format>.

+ specified by <internal_format>. Must be one of the following symbolic constants:

reveman 2014/08/11 18:37:21 Please format this comment so each line is 80 char

dshwang 2014/08/11 19:48:08 Done.

+ GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, or GL_RGBA.

+ When <source_id> texture doens't contain a superset of the component required by <internal_format>,

+ fill the components by following rules although glCopyImage2D generates GL_INVALID_OPERATION in this case.

reveman 2014/08/11 18:37:21 what is glCopyImage2D? and why is it relevant to m

dshwang 2014/08/11 19:48:08 Done. Remove it.

+ source format color components

+ =================================================

+ GL_ALPHA (0, 0, 0, A)

+ GL_LUMINANCE (L, L, L, 1)

+ GL_LUMINANCE_ALPHA (L, L, L, A)

+ GL_RGB (R, G, B, 1)

+ GL_RGBA (R, G, B, A)

dshwang 2014/08/11 14:08:12 It's actually the rule of texture2d() built-in fun

reveman 2014/08/11 18:37:21 Acknowledged.

The format type of the destination texture is converted to that specified

by <dest_type>.