gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt - Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix window's webgl conformance test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/gpu/media/android_video_decode_accelerator.cc ('k') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_copy_texture	3 CHROMIUM_copy_texture

4	4

5 Name Strings	5 Name Strings

6	6

7 GL_CHROMIUM_copy_texture	7 GL_CHROMIUM_copy_texture

8	8

9 Version	9 Version

10	10

(...skipping 29 matching lines...) Expand all Loading...
40 GLenum dest_id, GLint level,	40 GLenum dest_id, GLint level,

41 GLint internal_format, GLenum dest_type)	41 GLint internal_format, GLenum dest_type)

42	42

43 Copies the contents of texture referred to by <source_id> to texture	43 Copies the contents of texture referred to by <source_id> to texture

44 <dest_id>.	44 <dest_id>.

45	45

46 Texture level 0 is copied from the source image to level <level> of the	46 Texture level 0 is copied from the source image to level <level> of the

47 destination texture. The level parameter must be 0 at present.	47 destination texture. The level parameter must be 0 at present.

48	48

49 The internal format of the destination texture is converted to that	49 The internal format of the destination texture is converted to that

50 specified by <internal_format>.	50 specified by <internal_format>. Must be one of the following symbolic consta nts:
	reveman 2014/08/11 18:37:21 Please format this comment so each line is 80 char Please format this comment so each line is 80 characters or less. dshwang 2014/08/11 19:48:08 Done. Show quoted text On 2014/08/11 18:37:21, reveman wrote: > Please format this comment so each line is 80 characters or less. Done.
	51 GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, or GL_RGBA.

	52 When <source_id> texture doens't contain a superset of the component require d by <internal_format>,

	53 fill the components by following rules although glCopyImage2D generates GL_I NVALID_OPERATION in this case.
	reveman 2014/08/11 18:37:21 what is glCopyImage2D? and why is it relevant to m what is glCopyImage2D? and why is it relevant to mention it as part of this spec? does the user of this extension need to know this? dshwang 2014/08/11 19:48:08 Done. Remove it. Show quoted text On 2014/08/11 18:37:21, reveman wrote: > what is glCopyImage2D? and why is it relevant to mention it as part of this > spec? does the user of this extension need to know this? Done. Remove it.
	54

	55 source format color components

	56 =================================================

	57 GL_ALPHA (0, 0, 0, A)

	58 GL_LUMINANCE (L, L, L, 1)

	59 GL_LUMINANCE_ALPHA (L, L, L, A)

	60 GL_RGB (R, G, B, 1)

	61 GL_RGBA (R, G, B, A)
	dshwang 2014/08/11 14:08:12 It's actually the rule of texture2d() built-in fun It's actually the rule of texture2d() built-in functions of glsl. So we don't need to do anything. I just clarify what's happen. reveman 2014/08/11 18:37:21 Acknowledged. Show quoted text On 2014/08/11 14:08:12, dshwang wrote: > It's actually the rule of texture2d() built-in functions of glsl. > So we don't need to do anything. I just clarify what's happen. Acknowledged.
51	62

52 The format type of the destination texture is converted to that specified	63 The format type of the destination texture is converted to that specified

53 by <dest_type>.	64 by <dest_type>.

54	65

55 <target> uses the same parameters as TexImage2D.	66 <target> uses the same parameters as TexImage2D.

56	67

57 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.	68 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.

58	69

59 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture	70 INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture

60 objects.	71 objects.

(...skipping 18 matching lines...) Expand all Loading...
79	90

80 New State	91 New State

81	92

82 None.	93 None.

83	94

84 Revision History	95 Revision History

85	96

86 8/1/2011 Documented the extension	97 8/1/2011 Documented the extension

87 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM()	98 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM()

88 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target.	99 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target.

OLD	NEW