Remove remaining callers of deprecatedShadowAncestorNode

Remove remaining callers of deprecatedShadowAncestorNode

Remove remaining callers of deprecatedShadowAncestorNode
and remove the same function from Node.h

BUG=234099
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177926

[deepak.sa, 2014-07-08 15:58:31]

Please have a look.
Thanks!

[tkent, 2014-07-08 23:33:02]

lgtm

https://codereview.chromium.org/374133002/diff/1/Source/core/page/FocusContro...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/374133002/diff/1/Source/core/page/FocusContro...
Source/core/page/FocusController.cpp:660: if
(selectionStartNode->isInShadowTree()) {
nit:
if (selectionStartNode->isInShadowTree() && selectionStartNode->shadowHost() ==
newFocusedNode)
    return;

https://codereview.chromium.org/374133002/diff/1/Source/core/testing/Internal...
File Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/374133002/diff/1/Source/core/testing/Internal...
Source/core/testing/Internals.cpp:1510: if (innerNode) {
nit:
if (Node* innerNode = result.innerNode()) {
    ....

[deepak.sa, 2014-07-10 13:52:03]

https://codereview.chromium.org/374133002/diff/1/Source/core/page/FocusContro...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/374133002/diff/1/Source/core/page/FocusContro...
Source/core/page/FocusController.cpp:660: if
(selectionStartNode->isInShadowTree()) {
On 2014/07/08 23:33:01, tkent wrote:
> nit:
> if (selectionStartNode->isInShadowTree() && selectionStartNode->shadowHost()
==
> newFocusedNode)
>     return;

Done.

https://codereview.chromium.org/374133002/diff/1/Source/core/testing/Internal...
File Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/374133002/diff/1/Source/core/testing/Internal...
Source/core/testing/Internals.cpp:1510: if (innerNode) {
On 2014/07/08 23:33:01, tkent wrote:
> nit:
> if (Node* innerNode = result.innerNode()) {
>     ....

Done.

[deepak.sa, 2014-07-11 05:05:14]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-07-11 05:06:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/374133002/20001

[commit-bot: I haz the power, 2014-07-11 05:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 05:06:15]

Failed to apply patch for Source/core/page/EventHandler.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/EventHandler.cpp
  Hunk #1 FAILED at 2499.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/EventHandler.cpp.rej

Patch:       Source/core/page/EventHandler.cpp
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp
b/Source/core/page/EventHandler.cpp
index
f02bbce05b9e47279bc664e816faf680e84d7f20..eaf6c3e995f8a101c4454f47b87e7216812d1ebb
100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -2499,8 +2499,10 @@ bool
EventHandler::bestClickableNodeForHitTestResult(const HitTestResult& result
     // FIXME: targetNode and success are only used by Internals functions. We
should
     // instead have dedicated test methods so we only do this work in tests.
     bool success = findBestClickableCandidate(targetNode, targetPoint,
touchCenter, touchRect, WillBeHeapVector<RefPtrWillBeMember<Node> > (nodes));
-    if (success && targetNode)
-        targetNode = targetNode->deprecatedShadowAncestorNode();
+    if (success && targetNode) {
+        if (targetNode->isInShadowTree())
+            targetNode = targetNode->shadowHost();
+    }
     return success;
 }

[deepak.sa, 2014-07-11 09:44:16]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-07-11 09:44:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/374133002/40001

[commit-bot: I haz the power, 2014-07-11 10:55:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-07-11 11:07:26]

Change committed as 177926