Source/core/page/FocusController.cpp - Issue 374133002: Remove remaining callers of deprecatedShadowAncestorNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.cpp

Issue 374133002: Remove remaining callers of deprecatedShadowAncestorNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/FocusController.cpp

diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp

index b8c2276bd90e38f1560f60bb9b8560fa61268158..2f3173962b8c6d642cf89752a69ac69d50b2852b 100644

--- a/Source/core/page/FocusController.cpp

+++ b/Source/core/page/FocusController.cpp

@@ -654,7 +654,10 @@ static void clearSelectionIfNeeded(LocalFrame* oldFocusedFrame, LocalFrame* newF

return;

Node* selectionStartNode = selection.selection().start().deprecatedNode();

- if (selectionStartNode == newFocusedNode || selectionStartNode->isDescendantOf(newFocusedNode) || selectionStartNode->deprecatedShadowAncestorNode() == newFocusedNode)

+ if (selectionStartNode == newFocusedNode || selectionStartNode->isDescendantOf(newFocusedNode))

+ return;

+ if (selectionStartNode->isInShadowTree() && selectionStartNode->shadowHost() == newFocusedNode)

return;

if (Node* mousePressNode = newFocusedFrame->eventHandler().mousePressNode()) {

« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »