LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml - Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/move-nodes-across-documents.html ('k') | LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt » ('j') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

diff --git a/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml b/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

index 56f3542a675b3c6da5d3d184ca9341728fa2e6e3..b3b815aa4057a9690729997094272512f49bf6d0 100644

--- a/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

+++ b/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

@@ -5,7 +5,7 @@

<![CDATA[

description("Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.");

var pi = document.createProcessingInstruction('target', 'data');

-shouldThrow("pi.appendChild(null)", '"HierarchyRequestError: Failed to execute \'appendChild\' on \'Node\': This node type does not support this method."');

+shouldThrow("pi.appendChild(null)", '"TypeError: Failed to execute \'appendChild\' on \'Node\': parameter 1 (\'newChild\') is not an object."');

var div = document.createElement('div');

shouldThrow("pi.appendChild(div)", '"HierarchyRequestError: Failed to execute \'appendChild\' on \'Node\': This node type does not support this method."');

var textNode = document.createTextNode('sometext');