LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml - Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/move-nodes-across-documents.html ('k') | LayoutTests/fast/dom/processing-instruction-appendChild-exceptions-expected.txt » ('j') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html xmlns="http://www.w3.org/1999/xhtml">	1 <html xmlns="http://www.w3.org/1999/xhtml">

2 <body>	2 <body>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <script>	4 <script>

5 <![CDATA[	5 <![CDATA[

6 description("Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.");	6 description("Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.");

7 var pi = document.createProcessingInstruction('target', 'data');	7 var pi = document.createProcessingInstruction('target', 'data');

8 shouldThrow("pi.appendChild(null)", '"HierarchyRequestError: Failed to execute \ 'appendChild\' on \'Node\': This node type does not support this method."');	8 shouldThrow("pi.appendChild(null)", '"TypeError: Failed to execute \'appendChild \' on \'Node\': parameter 1 (\'newChild\') is not an object."');

9 var div = document.createElement('div');	9 var div = document.createElement('div');

10 shouldThrow("pi.appendChild(div)", '"HierarchyRequestError: Failed to execute \' appendChild\' on \'Node\': This node type does not support this method."');	10 shouldThrow("pi.appendChild(div)", '"HierarchyRequestError: Failed to execute \' appendChild\' on \'Node\': This node type does not support this method."');

11 var textNode = document.createTextNode('sometext');	11 var textNode = document.createTextNode('sometext');

12 shouldThrow("pi.appendChild(textNode)", '"HierarchyRequestError: Failed to execu te \'appendChild\' on \'Node\': This node type does not support this method."');	12 shouldThrow("pi.appendChild(textNode)", '"HierarchyRequestError: Failed to execu te \'appendChild\' on \'Node\': This node type does not support this method."');

13 ]]>	13 ]]>

14 </script>	14 </script>

15 </body>	15 </body>

16 </html>	16 </html>

OLD	NEW