Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 373903002: guard registering mallocpixelref for chrome (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

guard registering mallocpixelref for chrome companion to https://codereview.chromium.org/320873003 NOTRY=True TBR= Committed: https://skia.googlesource.com/skia/+/3230517a77431b3680f4b44a0cc891786dd80998

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ports/SkGlobalInitialization_chromium.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-07 21:54:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/373903002/20001
6 years, 5 months ago (2014-07-07 21:55:20 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 21:55:20 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 5 months ago (2014-07-07 21:55:21 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-07 21:58:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/373903002/20001
6 years, 5 months ago (2014-07-07 21:59:23 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 21:59:36 UTC) #7
Message was sent while issue was closed.
Change committed as 3230517a77431b3680f4b44a0cc891786dd80998

Powered by Google App Engine
This is Rietveld 408576698