Issue 320873003: change pixelref to not inherit from SkFlattenable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320873003: change pixelref to not inherit from SkFlattenable (Closed)

Created:
6 years, 6 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

change pixelref to not inherit from SkFlattenable If I can "inline" MallocPixelRef unflatten, then I think we can delete this code. The only caller today should be unflattening in the legacy path for bitmaps. Committed: https://skia.googlesource.com/skia/+/9a9eae21ed5235869702a66d6decddd6643792c3

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -39 lines)			Patch
M	include/core/SkMallocPixelRef.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	include/core/SkPixelRef.h	View	1	5 chunks	+15 lines, -3 lines	0 comments	Download
M	include/core/SkReadBuffer.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/core/SkMallocPixelRef.cpp	View	1	2 chunks	+2 lines, -15 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1	3 chunks	+2 lines, -17 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/lazy/SkCachingPixelRef.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/320873003/20001

6 years, 5 months ago (2014-07-07 20:51:57 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-07 21:32:10 UTC) #5

Message was sent while issue was closed.

Change committed as 9a9eae21ed5235869702a66d6decddd6643792c3