Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: pdfium.gyp

Issue 373643002: Do not disable warnings-as-errors for pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 34d69594308025d2032f6325acddd31afba37cdf..494660f6a6a63b2e4a9537b77243b5113ebd7a63 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -1,6 +1,5 @@
{
'variables': {
- 'win_third_party_warn_as_error': 'false',
'pdf_use_skia%': 0,
},
'target_defaults': {
@@ -37,14 +36,8 @@
['OS=="mac"', {
'xcode_settings': {
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
- 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror
},
}],
- ['clang==1', {
- 'cflags!': [
- '-Werror',
- ],
- }],
],
'msvs_disabled_warnings': [
4005, 4018, 4146, 4333, 4345
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698