Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: pdfium.gyp

Issue 373643002: Do not disable warnings-as-errors for pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'win_third_party_warn_as_error': 'false',
4 'pdf_use_skia%': 0, 3 'pdf_use_skia%': 0,
5 }, 4 },
6 'target_defaults': { 5 'target_defaults': {
7 'defines' : [ 6 'defines' : [
8 'FOXIT_CHROME_BUILD', 7 'FOXIT_CHROME_BUILD',
9 '_FXFT_VERSION_=2501', 8 '_FXFT_VERSION_=2501',
10 '_FPDFSDK_LIB', 9 '_FPDFSDK_LIB',
11 '_NO_GDIPLUS_', # workaround text rendering issues on Windows 10 '_NO_GDIPLUS_', # workaround text rendering issues on Windows
12 ], 11 ],
13 'conditions': [ 12 'conditions': [
(...skipping 16 matching lines...) Expand all
30 ['target_arch=="ia32"', { 29 ['target_arch=="ia32"', {
31 'defines' : [ 30 'defines' : [
32 '_FX_CPU_=_FX_X86_', 31 '_FX_CPU_=_FX_X86_',
33 ], 32 ],
34 }], 33 }],
35 ], 34 ],
36 }], 35 }],
37 ['OS=="mac"', { 36 ['OS=="mac"', {
38 'xcode_settings': { 37 'xcode_settings': {
39 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES', 38 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
40 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror
41 }, 39 },
42 }], 40 }],
43 ['clang==1', {
44 'cflags!': [
45 '-Werror',
46 ],
47 }],
48 ], 41 ],
49 'msvs_disabled_warnings': [ 42 'msvs_disabled_warnings': [
50 4005, 4018, 4146, 4333, 4345 43 4005, 4018, 4146, 4333, 4345
51 ], 44 ],
52 }, 45 },
53 'targets': [ 46 'targets': [
54 { 47 {
55 'target_name': 'pdfium', 48 'target_name': 'pdfium',
56 'type': 'static_library', 49 'type': 'static_library',
57 'dependencies': [ 50 'dependencies': [
(...skipping 798 matching lines...) Expand 10 before | Expand all | Expand 10 after
856 'fpdfsdk/src/formfiller/FFL_ListBox.cpp', 849 'fpdfsdk/src/formfiller/FFL_ListBox.cpp',
857 'fpdfsdk/src/formfiller/FFL_Notify.cpp', 850 'fpdfsdk/src/formfiller/FFL_Notify.cpp',
858 'fpdfsdk/src/formfiller/FFL_PushButton.cpp', 851 'fpdfsdk/src/formfiller/FFL_PushButton.cpp',
859 'fpdfsdk/src/formfiller/FFL_RadioButton.cpp', 852 'fpdfsdk/src/formfiller/FFL_RadioButton.cpp',
860 'fpdfsdk/src/formfiller/FFL_TextField.cpp', 853 'fpdfsdk/src/formfiller/FFL_TextField.cpp',
861 'fpdfsdk/src/formfiller/FFL_Utils.cpp', 854 'fpdfsdk/src/formfiller/FFL_Utils.cpp',
862 ], 855 ],
863 }, 856 },
864 ], 857 ],
865 } 858 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698