Do not disable warnings-as-errors for pdfium.

Do not disable warnings-as-errors for pdfium.

It currently doesn't have any build warnings, and this way the
chromium build is guaranteed to stay warning-free after pdfium rolls.

BUG=none
R=jam@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3d07b6f

[jam, 2014-07-14 22:50:48]

will this also apply to third party code inside pdfium? i.e. code from Foxit we
can control, but what if there's a new version of libjpeg, fontconfig etc? I'm
hesitant to have to change those libraries since it'll make updating them
harder.

[Nico, 2014-07-15 21:46:21]

On 2014/07/14 22:50:48, jam wrote:
> will this also apply to third party code inside pdfium? i.e. code from Foxit
we
> can control, but what if there's a new version of libjpeg, fontconfig etc? I'm
> hesitant to have to change those libraries since it'll make updating them
> harder.

Yes, this applies to third-party code too. But if new third-party code has
warnings, you can explicitly disable these for just the third-party libraries,
that's how we handle this in Chromium.

[jam, 2014-07-16 18:30:24]

On 2014/07/15 21:46:21, Nico (away) wrote:
> On 2014/07/14 22:50:48, jam wrote:
> > will this also apply to third party code inside pdfium? i.e. code from Foxit
> we
> > can control, but what if there's a new version of libjpeg, fontconfig etc?
I'm
> > hesitant to have to change those libraries since it'll make updating them
> > harder.
> 
> Yes, this applies to third-party code too. But if new third-party code has
> warnings, you can explicitly disable these for just the third-party libraries,
> that's how we handle this in Chromium.

lgtm

[Nico, 2014-07-16 20:44:31]

Committed patchset #1 manually as r3d07b6f (presubmit successful).