chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc - Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CrOS test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | components/dom_distiller/content/distiller_page_web_contents.h » ('j') | components/dom_distiller/content/dom_distiller_viewer_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

index 1cb3ac49c7e65fc2bcc6f575d83c1132c2bb51cb..2c0ddf88f969e9f04ad8ac7becfefc529d3f6ae1 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

@@ -97,7 +97,8 @@ class PermissionBubbleManagerTest : public ChromeRenderViewHostTestHarness {

}

void WaitForFrameLoad() {

- manager_->DocumentLoadedInFrame(0, NULL);

+ // PermissionBubbleManager ignores all parameters. Yay?

+ manager_->DocumentLoadedInFrame(NULL);

base::MessageLoop::current()->RunUntilIdle();

}