chrome/browser/ui/website_settings/permission_bubble_manager.cc - Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CrOS test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

index 15c0acadae965a6d6b507c5d4904b7ffae238760..e54e40a2480612b167f3ce8f26f77595a096126b 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

@@ -223,8 +223,7 @@ void PermissionBubbleManager::DocumentOnLoadCompletedInMainFrame() {

}

void PermissionBubbleManager::DocumentLoadedInFrame(

- int64 frame_id,

- content::RenderViewHost* render_view_host) {

+ content::RenderFrameHost* render_frame_host) {

if (request_url_has_loaded_)

ScheduleShowBubble();

}