chrome/browser/ui/search/search_tab_helper.h - Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CrOS test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.h

diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h

index e1314e5bc17910a3027620f65e1817971a440544..030d2a6230cc095291805ac74f32d5424e94d744 100644

--- a/chrome/browser/ui/search/search_tab_helper.h

+++ b/chrome/browser/ui/search/search_tab_helper.h

@@ -154,11 +154,8 @@ class SearchTabHelper : public content::WebContentsObserver,

const GURL& validated_url,

int error_code,

const base::string16& error_description) OVERRIDE;

- virtual void DidFinishLoad(

- int64 frame_id,

- const GURL& validated_url,

- bool is_main_frame,

- content::RenderViewHost* render_view_host) OVERRIDE;

+ virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host,

+ const GURL& validated_url) OVERRIDE;

virtual void NavigationEntryCommitted(

const content::LoadCommittedDetails& load_details) OVERRIDE;