chrome/browser/ui/search/search_tab_helper.cc - Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CrOS test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index 015d633335ccfcba367aba83e26eb2e2d6296659..8b0f7b3e2111decf91fceadd4605bfab2d981113 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -339,12 +339,9 @@ void SearchTabHelper::DidFailProvisionalLoad(

}

-void SearchTabHelper::DidFinishLoad(

- int64 /* frame_id */,

- const GURL& /* validated_url */,

- bool is_main_frame,

- content::RenderViewHost* /* render_view_host */) {

- if (is_main_frame) {

+void SearchTabHelper::DidFinishLoad(content::RenderFrameHost* render_frame_host,

+ const GURL& /* validated_url */) {

+ if (!render_frame_host->GetParent()) {

if (chrome::IsInstantNTP(web_contents_))

RecordNewTabLoadTime(web_contents_);