Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 37353002: Auto-rebaseline for r160257 (Closed)

Created:
7 years, 1 month ago by ojan
Modified:
7 years, 1 month ago
CC:
blink-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -18 lines 0 comments Download
A + LayoutTests/platform/mac-lion/fast/events/scale-and-scroll-iframe-body-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-lion/fast/events/scale-and-scroll-iframe-window-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-lion/fast/frames/frame-set-rotation-hit-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-lion/fast/frames/frame-set-scaling-hit-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-lion/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-e-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-n-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-ne-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-nw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-s-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-se-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-size-change-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-sw-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/compositing/rubberbanding/transform-overhang-w-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/fast/events/scale-and-scroll-iframe-body-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/fast/events/scale-and-scroll-iframe-window-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/fast/frames/frame-set-rotation-hit-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-retina/fast/frames/frame-set-scaling-hit-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-retina/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/compositing/fixed-body-background-positioned-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/fixed-body-background-positioned-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-e-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-n-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-ne-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-nw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-s-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-se-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-size-change-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-sw-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-w-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/events/scale-and-scroll-iframe-body-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/events/scale-and-scroll-iframe-window-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/frames/frame-set-rotation-hit-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/frames/frame-set-scaling-hit-expected.png View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
Committed patchset #1 manually as r160339 (presubmit successful).
7 years, 1 month ago (2013-10-23 14:38:45 UTC) #1
Alexei Svitkine (slow)
Hmm, the new baselines are missing the overhang texture image, e.g.: https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-ne-expected.png That doesn't seem ...
7 years, 1 month ago (2013-10-23 14:42:48 UTC) #2
ccameron
On 2013/10/23 14:42:48, Alexei Svitkine wrote: > Hmm, the new baselines are missing the overhang ...
7 years, 1 month ago (2013-10-23 17:58:10 UTC) #3
ccameron
On 2013/10/23 17:58:10, ccameron1 wrote: > On 2013/10/23 14:42:48, Alexei Svitkine wrote: > > Hmm, ...
7 years, 1 month ago (2013-10-24 00:10:37 UTC) #4
ccameron
7 years, 1 month ago (2013-10-24 00:22:26 UTC) #5
Message was sent while issue was closed.
On 2013/10/24 00:10:37, ccameron1 wrote:
> On 2013/10/23 17:58:10, ccameron1 wrote:
> > On 2013/10/23 14:42:48, Alexei Svitkine wrote:
> > > Hmm, the new baselines are missing the overhang texture image, e.g.:
> > > 
> > >
> >
>
https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/comp...
> > > 
> > > That doesn't seem right. We need test coverage that ensures the texture
gets
> > > drawn....
> > 
> > Yeah, it looks like it's flakily drawing or not drawing them -- see
> > crbug.com/310679 (grumble...)
> 
> Half of the links in the above codereview are broken, and the rest of them
(e.g,
>
LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-w-expected.png)
> don't correspond to what I see in my local checkout (which has this version).
> 
> So I don't know what to make of this. Plus, all of the (suppressed) failures
> show the bad image (the one with the white instead of the linen)...

Okay -- this rebaseline was reverted at https://codereview.chromium.org/37383002

Now things make sense!

Powered by Google App Engine
This is Rietveld 408576698