Committed patchset #1 manually as r160339 (presubmit successful).
Alexei Svitkine (slow)
Hmm, the new baselines are missing the overhang texture image, e.g.: https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-ne-expected.png That doesn't seem ...
On 2013/10/23 14:42:48, Alexei Svitkine wrote:
> Hmm, the new baselines are missing the overhang texture image, e.g.:
>
>
https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/comp...
>
> That doesn't seem right. We need test coverage that ensures the texture gets
> drawn....
Yeah, it looks like it's flakily drawing or not drawing them -- see
crbug.com/310679 (grumble...)
ccameron
On 2013/10/23 17:58:10, ccameron1 wrote: > On 2013/10/23 14:42:48, Alexei Svitkine wrote: > > Hmm, ...
On 2013/10/23 17:58:10, ccameron1 wrote:
> On 2013/10/23 14:42:48, Alexei Svitkine wrote:
> > Hmm, the new baselines are missing the overhang texture image, e.g.:
> >
> >
>
https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/comp...
> >
> > That doesn't seem right. We need test coverage that ensures the texture gets
> > drawn....
>
> Yeah, it looks like it's flakily drawing or not drawing them -- see
> crbug.com/310679 (grumble...)
Half of the links in the above codereview are broken, and the rest of them (e.g,
LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-w-expected.png)
don't correspond to what I see in my local checkout (which has this version).
So I don't know what to make of this. Plus, all of the (suppressed) failures
show the bad image (the one with the white instead of the linen)...
ccameron
On 2013/10/24 00:10:37, ccameron1 wrote: > On 2013/10/23 17:58:10, ccameron1 wrote: > > On 2013/10/23 ...
On 2013/10/24 00:10:37, ccameron1 wrote:
> On 2013/10/23 17:58:10, ccameron1 wrote:
> > On 2013/10/23 14:42:48, Alexei Svitkine wrote:
> > > Hmm, the new baselines are missing the overhang texture image, e.g.:
> > >
> > >
> >
>
https://codereview.chromium.org/37353002/diff/1/LayoutTests/platform/mac/comp...
> > >
> > > That doesn't seem right. We need test coverage that ensures the texture
gets
> > > drawn....
> >
> > Yeah, it looks like it's flakily drawing or not drawing them -- see
> > crbug.com/310679 (grumble...)
>
> Half of the links in the above codereview are broken, and the rest of them
(e.g,
>
LayoutTests/platform/mac/compositing/rubberbanding/transform-overhang-w-expected.png)
> don't correspond to what I see in my local checkout (which has this version).
>
> So I don't know what to make of this. Plus, all of the (suppressed) failures
> show the bad image (the one with the white instead of the linen)...
Okay -- this rebaseline was reverted at https://codereview.chromium.org/37383002
Now things make sense!
Issue 37353002: Auto-rebaseline for r160257
(Closed)
Created 7 years, 1 month ago by ojan
Modified 7 years, 1 month ago
Reviewers: ccameron, Alexei Svitkine (slow)
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0