chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 373043003: Password bubble: Don't focus by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 373043003: Password bubble: Don't focus by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 11f4e87737c3d0a90afa0c2ea9d0753f487ef4e3..2617928f31f210e96187dca7cfdb598a732fe67a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -80,6 +80,10 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

// Open with pending password: automagical!

SetupPendingPassword();

+ // Bubble should not be focused by default.

+ EXPECT_FALSE(

+ ManagePasswordsBubbleView::Bubble()->GetFocusManager()->GetFocusedView());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));

EXPECT_EQ(

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | no next file » | no next file with comments »