Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: tools/perf/benchmarks/pica.py

Issue 373033005: Update pica to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/pica.py
diff --git a/tools/perf/benchmarks/pica.py b/tools/perf/benchmarks/pica.py
index eff3866f45b9f68e99be563adc656d4769664fc3..ab33b9631191f6736ed7e6661cb12ce3d659c8ac 100644
--- a/tools/perf/benchmarks/pica.py
+++ b/tools/perf/benchmarks/pica.py
@@ -5,6 +5,7 @@
import page_sets
from telemetry import benchmark
from telemetry.page import page_measurement
+from telemetry.value import scalar
class _PicaMeasurement(page_measurement.PageMeasurement):
def CustomizeBrowserOptions(self, options):
@@ -14,7 +15,8 @@ class _PicaMeasurement(page_measurement.PageMeasurement):
def MeasurePage(self, _, tab, results):
result = int(tab.EvaluateJavaScript('__polymer_ready_time'))
- results.Add('Total', 'ms', result)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'Total', 'ms', result))
class Pica(benchmark.Benchmark):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698