Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/perf/benchmarks/pica.py

Issue 373033005: Update pica to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import page_sets 5 import page_sets
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.page import page_measurement 7 from telemetry.page import page_measurement
8 from telemetry.value import scalar
8 9
9 class _PicaMeasurement(page_measurement.PageMeasurement): 10 class _PicaMeasurement(page_measurement.PageMeasurement):
10 def CustomizeBrowserOptions(self, options): 11 def CustomizeBrowserOptions(self, options):
11 # Needed for native custom elements (document.register) 12 # Needed for native custom elements (document.register)
12 options.AppendExtraBrowserArgs( 13 options.AppendExtraBrowserArgs(
13 '--enable-experimental-web-platform-features') 14 '--enable-experimental-web-platform-features')
14 15
15 def MeasurePage(self, _, tab, results): 16 def MeasurePage(self, _, tab, results):
16 result = int(tab.EvaluateJavaScript('__polymer_ready_time')) 17 result = int(tab.EvaluateJavaScript('__polymer_ready_time'))
17 results.Add('Total', 'ms', result) 18 results.AddValue(scalar.ScalarValue(
19 results.current_page, 'Total', 'ms', result))
18 20
19 21
20 class Pica(benchmark.Benchmark): 22 class Pica(benchmark.Benchmark):
21 test = _PicaMeasurement 23 test = _PicaMeasurement
22 page_set = page_sets.PicaPageSet 24 page_set = page_sets.PicaPageSet
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698