Issue 372903002: HandleScope::ZapRange is hot function using oprofile, so release version disable v8_enable_handle_z…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372903002: HandleScope::ZapRange is hot function using oprofile, so release version disable v8_enable_handle_z… (Closed)

Created:
6 years, 5 months ago by jianghua

Modified:
4 years, 1 month ago

Reviewers:
Yang, danno

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

HandleScope::ZapRange is hot function using oprofile, so release version disable v8_enable_handle_zapping. BUG=

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/features.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jianghua

CPU: CPU with timer interrupt, speed 2472.74 MHz (estimated) Profiling through timer interrupt samples % ...

6 years, 5 months ago (2014-07-09 05:43:47 UTC) #1

danno

6 years, 5 months ago (2014-07-09 06:37:33 UTC) #2

This is working as intended. Handle zapping is on by default in bleeding edge to
help embedders (e.g. the Chromium project) find API misusage during development.
It gets disabled for each release branch, so in practice it is not a performance
issue.

Expand Messages | Collapse Messages