Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issue 3729003: Add plumbing for passing the indexed database quota via IDBFactory::open (Closed)

Created:
9 years, 1 month ago by andreip3000
Modified:
8 years, 5 months ago
Reviewers:
jorlow
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add plumbing for passing the indexed database quota via IDBFactory::open BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62352

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address Jeremy's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/render_messages_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages_params.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_webidbfactory_impl.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_webidbfactory_impl.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
andreip3000
9 years, 1 month ago (2010-10-12 01:56:54 UTC) #1
jorlow
http://codereview.chromium.org/3729003/diff/1/2 File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): http://codereview.chromium.org/3729003/diff/1/2#newcode53 chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: static const uint64 kDatabaseQuota = 5 * 1024 * ...
9 years, 1 month ago (2010-10-12 02:08:04 UTC) #2
andreip3000
http://codereview.chromium.org/3729003/diff/1/2 File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): http://codereview.chromium.org/3729003/diff/1/2#newcode53 chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: static const uint64 kDatabaseQuota = 5 * 1024 * ...
9 years, 1 month ago (2010-10-12 02:33:55 UTC) #3
jorlow
9 years, 1 month ago (2010-10-12 02:42:45 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698