Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 372273003: Add missing / in android_gdbserver (Closed)

Created:
6 years, 5 months ago by Tom Hudson
Modified:
6 years, 5 months ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add missing / in android_gdbserver Introduced in https://codereview.chromium.org/22617002, apparently worked just fine, at least on already-set-up devices. Failing at least since https://codereview.chromium.org/352303003/. BUG=skia:2729 R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/f9552230dc0d15fd1c535ad6351c3a8edde5ac82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
djsollen
lgtm
6 years, 5 months ago (2014-07-08 19:16:01 UTC) #1
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 5 months ago (2014-07-08 19:16:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/372273003/1
6 years, 5 months ago (2014-07-08 19:17:07 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:30:01 UTC) #4
Message was sent while issue was closed.
Change committed as f9552230dc0d15fd1c535ad6351c3a8edde5ac82

Powered by Google App Engine
This is Rietveld 408576698