Issue 22617002: Update Skia Android tools.

Issue 22617002: Update Skia Android tools. (Closed)

Created:
7 years, 4 months ago by djsollen

Modified:
7 years, 4 months ago

Reviewers:
scroggo, borenet, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Update Skia Android tools. This CL moves the skia_launcher out of the system/bin and into /data/local/tmp; removes the need to package our shared libs in an apk; and updates all the scripts to work in the new environment. R=mtklein@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=10673

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing runtime error #

Patch Set 3 : more fixes to make the bots happy #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -510 lines)			Patch
M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/apptype_console.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/most.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	platform_tools/android/app/AndroidManifest.xml	View		1 chunk	+0 lines, -8 lines	0 comments	Download
D	platform_tools/android/app/jni/com_skia_SkiaIntentService.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	platform_tools/android/app/jni/com_skia_SkiaIntentService.cpp	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	platform_tools/android/app/src/com/skia/SkiaIntentService.java	View		1 chunk	+0 lines, -94 lines	0 comments	Download
D	platform_tools/android/app/src/com/skia/SkiaReceiver.java	View		1 chunk	+0 lines, -26 lines	0 comments	Download
D	platform_tools/android/bin/android_gdb	View		1 chunk	+0 lines, -62 lines	0 comments	Download
A +	platform_tools/android/bin/android_gdb_apk	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	platform_tools/android/bin/android_gdbserver	View	1 2	1 chunk	+34 lines, -26 lines	0 comments	Download
A +	platform_tools/android/bin/android_install_apk	View	1 2	4 chunks	+2 lines, -25 lines	0 comments	Download
M	platform_tools/android/bin/android_install_skia	View		1 chunk	+2 lines, -74 lines	0 comments	Download
M	platform_tools/android/bin/android_make	View		1 chunk	+1 line, -1 line	0 comments	Download
M	platform_tools/android/bin/android_perf	View	1 2	4 chunks	+47 lines, -60 lines	0 comments	Download
M	platform_tools/android/bin/android_run_skia	View	1 2	1 chunk	+19 lines, -32 lines	0 comments	Download
M	platform_tools/android/bin/android_setup.sh	View	1 2	3 chunks	+51 lines, -6 lines	0 comments	Download
A	platform_tools/android/bin/linux/perfhost	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	platform_tools/android/gyp/dependencies.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	platform_tools/android/gyp/skia_android.gypi	View		4 chunks	+3 lines, -24 lines	0 comments	Download
M	platform_tools/android/launcher/skia_launcher.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/22617002/diff/1/platform_tools/android/bin/android_gdb File platform_tools/android/bin/android_gdb (left): https://codereview.chromium.org/22617002/diff/1/platform_tools/android/bin/android_gdb#oldcode3 platform_tools/android/bin/android_gdb:3: # android_gdb: Pushes parameter binary and gdbserver. Connects ...

7 years, 4 months ago (2013-08-07 19:47:02 UTC) #3

djsollen

On 2013/08/07 19:47:02, scroggo wrote: > lgtm > > https://codereview.chromium.org/22617002/diff/1/platform_tools/android/bin/android_gdb > File platform_tools/android/bin/android_gdb (left): > ...

7 years, 4 months ago (2013-08-07 20:33:43 UTC) #4

djsollen

7 years, 4 months ago (2013-08-12 12:31:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r10673 (presubmit successful).

Expand Messages | Collapse Messages