Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 37223002: Align SameSizeAsFillLayer with FillLayer (Closed)

Created:
7 years, 2 months ago by davve
Modified:
6 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Align SameSizeAsFillLayer with FillLayer After http://crrev.com/35303002/ added a bit in FillLayer, it was discovered that SameSizeAsFillLayer was slightly out-of-date (by 11 bits). Remove ambition to track the number of used bits in each bit field since it easily goes out-of-date and doesn't serve a useful purpose. BUG=304721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164932

Patch Set 1 #

Patch Set 2 : Address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/rendering/style/FillLayer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
davve
7 years, 2 months ago (2013-10-23 13:25:49 UTC) #1
davve
No interest in this? I felt a little bad for making it more out-of-sync in ...
7 years, 1 month ago (2013-10-31 16:06:42 UTC) #2
leviw_travelin_and_unemployed
I think I'd rather just see the specified bits there go away since they clearly ...
7 years, 1 month ago (2013-11-07 20:03:42 UTC) #3
davve
On 2013/11/07 20:03:42, Levi wrote: > I think I'd rather just see the specified bits ...
7 years, 1 month ago (2013-11-11 14:54:51 UTC) #4
davve
Julien, what do you think? There are a number of other places (SameSizeAsNodeRareData, SameSizeAsFloatingObject, etc) ...
6 years, 11 months ago (2014-01-10 15:41:10 UTC) #5
leviw_travelin_and_unemployed
Works for me. LGTM.
6 years, 11 months ago (2014-01-10 20:14:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/37223002/60001
6 years, 11 months ago (2014-01-11 08:44:20 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 10:26:25 UTC) #8
Message was sent while issue was closed.
Change committed as 164932

Powered by Google App Engine
This is Rietveld 408576698