Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 35303002: Unstick background position origins (Closed)

Created:
7 years, 2 months ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews, zoltan1, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Unstick background position origins In the FillLayer class, reset the {x,y} origins each time {x,y} position is set and require the caller to later call setBackground{X,Y}Origin to override the default value. This fits better with the way 'initial' values are set from the StyleBuilder and avoids the problem of origins lingering in the FillLayer when setting the 2-value versions of background-position. Furthermore, split the flag m_backgroundOriginSet into one for each property so that something like 'background-position-x:initial' won't reset the position origin for both properties. Also, remove code for handling 'initial' for {x,y} position, 'initial' is already handled in the StyleBuilder further up the call chain. BUG=304721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160243

Patch Set 1 #

Patch Set 2 : Re-upload in an attempt to avoid 'old chunk mismatch' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -29 lines) Patch
A LayoutTests/fast/backgrounds/background-position-origin.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-position-origin-expected.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-position-origin-initial.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-position-origin-initial-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-position-x-origin.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fast/backgrounds/background-position-x-origin-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/rendering/style/FillLayer.h View 5 chunks +12 lines, -10 lines 0 comments Download
M Source/core/rendering/style/FillLayer.cpp View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
7 years, 2 months ago (2013-10-22 14:33:08 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 1 month ago (2013-10-22 17:27:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/35303002/30001
7 years, 1 month ago (2013-10-22 17:28:17 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-22 19:24:26 UTC) #4
Message was sent while issue was closed.
Change committed as 160243

Powered by Google App Engine
This is Rietveld 408576698