Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 372173002: Revert of Swipe Gestures for Accessibility (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gesture-vlogs
Project:
chromium
Visibility:
Public.

Description

Revert of Swipe Gestures for Accessibility (https://codereview.chromium.org/330763007/) Reason for revert: TouchExplorationTest.GestureSwipe is failing on "Linux Chromium OS ASan LSan Tests (3)" http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2159 Original issue's description: > Swipe Gestures for Accessibility > > Register that gestures have been received by the touch_exploration_controller in Accessibility Mode. > > Swipe gestures are registered when the user begins a swipe and completes it before the time out period. If a swipe is successfully completed, the keyboard shortcut <shift>+<search>+direction will called. > > If the grace period has elapsed, then the mode changes to touch exploration. If an additional finger has been added before the grace period has elapsed, then the mode changes to passthrough. > > BUG=387304 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281614 TBR=lisayin@chromium.org,dmazzoni@chromium.org,tdresser@chromium.org,evy@chromium.org,aboxhall@chromium.org NOTREECHECKS=true NOTRY=true BUG=387304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -532 lines) Patch
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 5 chunks +8 lines, -47 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 10 chunks +3 lines, -49 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 16 chunks +31 lines, -166 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 48 chunks +40 lines, -270 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
Created Revert of Swipe Gestures for Accessibility
6 years, 5 months ago (2014-07-08 03:59:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/372173002/1
6 years, 5 months ago (2014-07-08 04:04:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 04:04:05 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 04:04:06 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-08 04:05:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/372173002/1
6 years, 5 months ago (2014-07-08 04:06:27 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 04:12:54 UTC) #7
Message was sent while issue was closed.
Change committed as 281656

Powered by Google App Engine
This is Rietveld 408576698