Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: tools/perf/benchmarks/sunspider.py

Issue 372163002: Refactor sunspider and scirra Telemetry benchmarks to use AddValue call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/scirra.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/sunspider.py
diff --git a/tools/perf/benchmarks/sunspider.py b/tools/perf/benchmarks/sunspider.py
index aef991d80906e600859474e943743756209b9200..166043c483966c2dc7231c983c3302ce1cf4ea58 100644
--- a/tools/perf/benchmarks/sunspider.py
+++ b/tools/perf/benchmarks/sunspider.py
@@ -9,6 +9,7 @@ from metrics import power
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import list_of_scalar_values
_URL = 'http://www.webkit.org/perf/sunspider-1.0.2/sunspider-1.0.2/driver.html'
@@ -50,8 +51,10 @@ class _SunspiderMeasurement(page_measurement.PageMeasurement):
total += value
totals.append(total)
for key, values in r.iteritems():
- results.Add(key, 'ms', values, data_type='unimportant')
- results.Add('Total', 'ms', totals)
+ results.AddValue(list_of_scalar_values.ListOfScalarValues(
+ results.current_page, key, 'ms', values, important=False))
+ results.AddValue(list_of_scalar_values.ListOfScalarValues(
+ results.current_page, 'Total', 'ms', totals))
class Sunspider(benchmark.Benchmark):
« no previous file with comments | « tools/perf/benchmarks/scirra.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698