Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/perf/benchmarks/scirra.py

Issue 372163002: Refactor sunspider and scirra Telemetry benchmarks to use AddValue call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/sunspider.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/scirra.py
diff --git a/tools/perf/benchmarks/scirra.py b/tools/perf/benchmarks/scirra.py
index 90cd386364b4416fb845631ddc0d22150ffc1558..77c9cd7dadac54c380ce3b19ee80c9e403d9df67 100644
--- a/tools/perf/benchmarks/scirra.py
+++ b/tools/perf/benchmarks/scirra.py
@@ -13,6 +13,7 @@ import os
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import scalar
class _ScirraMeasurement(page_measurement.PageMeasurement):
@@ -47,8 +48,8 @@ class _ScirraMeasurement(page_measurement.PageMeasurement):
""" % {'tickcount': tickcount, 'fps': fps, 'object_count': object_count}
tab.WaitForJavaScriptExpression(js_is_done, 300)
total = int(tab.EvaluateJavaScript('window.sprites'))
- results.Add('Count', 'count', total)
-
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'Count', 'count', total))
@benchmark.Disabled
class ScirraBenchmark(benchmark.Benchmark):
« no previous file with comments | « no previous file | tools/perf/benchmarks/sunspider.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698