Issue 372163002: Refactor sunspider and scirra Telemetry benchmarks to use AddValue call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372163002: Refactor sunspider and scirra Telemetry benchmarks to use AddValue call (Closed)

Created:
6 years, 5 months ago by eakuefner

Modified:
6 years, 5 months ago

Reviewers:
nednguyen, nduca

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Refactor sunspider and scirra Telemetry benchmarks to use AddValue call We are systematically removing results.Add() callsites and replacing them with results.AddValue() callsites. I've done scirra.py and sunspider.py, and nednguyen@ is doing more in the tools/perf directory. BUG=346958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281676

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	tools/perf/benchmarks/scirra.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	tools/perf/benchmarks/sunspider.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eakuefner

As discussed over IM with nednguyen@ I've done these two in the tools/perf directory but ...

6 years, 5 months ago (2014-07-08 00:22:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eakuefner@chromium.org/372163002/1

6 years, 5 months ago (2014-07-08 00:58:00 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...

6 years, 5 months ago (2014-07-08 03:29:58 UTC) #4

Message was sent while issue was closed.

Change committed as 281676

Expand Messages | Collapse Messages