Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 372068: Removes TabStrip::CanUpdateDisplay as it lead to crashes on the... (Closed)

Created:
11 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, James Hawkins
Visibility:
Public.

Description

Removes TabStrip::CanUpdateDisplay as it lead to crashes on the windows side. BUG=24132 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 3 chunks +16 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sky
11 years, 1 month ago (2009-11-09 21:14:53 UTC) #1
sky
Looks like James is out for another day. Tony, could you review this? Thanks, -Scott
11 years, 1 month ago (2009-11-10 17:56:38 UTC) #2
sky
Looks like James is out for another day. Tony, could you review this? Thanks, -Scott ...
11 years, 1 month ago (2009-11-10 17:56:59 UTC) #3
sky
Looks like James is out for another day. Tony, could you review this? Thanks, -Scott ...
11 years, 1 month ago (2009-11-10 18:03:02 UTC) #4
sky
Looks like James is out for another day. Tony, could you review this? Thanks, -Scott ...
11 years, 1 month ago (2009-11-10 18:13:04 UTC) #5
tony
I see, so you're removing it to make it consistent with the Views code? As ...
11 years, 1 month ago (2009-11-10 18:22:59 UTC) #6
sky
Looks like James is out for another day. Tony, could you review this? Thanks, -Scott ...
11 years, 1 month ago (2009-11-10 18:23:06 UTC) #7
tony
I see, so you're removing it to make it consistent with the Views code? As ...
11 years, 1 month ago (2009-11-10 18:23:31 UTC) #8
tony
I see, so you're removing it to make it consistent with the Views code? As ...
11 years, 1 month ago (2009-11-10 18:29:22 UTC) #9
sky
11 years, 1 month ago (2009-11-10 18:33:08 UTC) #10
Looks like James is out for another day. Tony, could you review this?

Thanks,

   -Scott

http://codereview.chromium.org/372068

Powered by Google App Engine
This is Rietveld 408576698