Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/gtk/tabs/tab_strip_gtk.h

Issue 372068: Removes TabStrip::CanUpdateDisplay as it lead to crashes on the... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/gtk/tabs/tab_strip_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_ 5 #ifndef CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_
6 #define CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_ 6 #define CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_
7 7
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 373
374 // Starts various types of TabStrip animations. 374 // Starts various types of TabStrip animations.
375 void StartInsertTabAnimation(int index); 375 void StartInsertTabAnimation(int index);
376 void StartRemoveTabAnimation(int index, TabContents* contents); 376 void StartRemoveTabAnimation(int index, TabContents* contents);
377 void StartMoveTabAnimation(int from_index, int to_index); 377 void StartMoveTabAnimation(int from_index, int to_index);
378 void StartResizeLayoutAnimation(); 378 void StartResizeLayoutAnimation();
379 void StartPinnedTabAnimation(int index); 379 void StartPinnedTabAnimation(int index);
380 void StartPinAndMoveTabAnimation(int from_index, int to_index, 380 void StartPinAndMoveTabAnimation(int from_index, int to_index,
381 const gfx::Rect& start_bounds); 381 const gfx::Rect& start_bounds);
382 382
383 // Returns true if detach or select changes in the model should be reflected
384 // in the TabStrip. This returns false if we're closing all tabs in the
385 // TabStrip and so we should prevent updating. This is not const because we
386 // use this as a signal to cancel any active animations.
387 bool CanUpdateDisplay();
388
389 // Notifies the TabStrip that the specified TabAnimation has completed. 383 // Notifies the TabStrip that the specified TabAnimation has completed.
390 // Optionally a full Layout will be performed, specified by |layout|. 384 // Optionally a full Layout will be performed, specified by |layout|.
391 void FinishAnimation(TabAnimation* animation, bool layout); 385 void FinishAnimation(TabAnimation* animation, bool layout);
392 386
393 NotificationRegistrar registrar_; 387 NotificationRegistrar registrar_;
394 388
395 // The Tabs we contain, and their last generated "good" bounds. 389 // The Tabs we contain, and their last generated "good" bounds.
396 std::vector<TabData> tab_data_; 390 std::vector<TabData> tab_data_;
397 391
398 // The current widths of various types of tabs. We save these so that, as 392 // The current widths of various types of tabs. We save these so that, as
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 // ResizeLayoutTabsNow method. 442 // ResizeLayoutTabsNow method.
449 ScopedRunnableMethodFactory<TabStripGtk> resize_layout_factory_; 443 ScopedRunnableMethodFactory<TabStripGtk> resize_layout_factory_;
450 444
451 // True if the tabstrip has already been added as a MessageLoop observer. 445 // True if the tabstrip has already been added as a MessageLoop observer.
452 bool added_as_message_loop_observer_; 446 bool added_as_message_loop_observer_;
453 447
454 DISALLOW_COPY_AND_ASSIGN(TabStripGtk); 448 DISALLOW_COPY_AND_ASSIGN(TabStripGtk);
455 }; 449 };
456 450
457 #endif // CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_ 451 #endif // CHROME_BROWSER_GTK_TABS_TAB_STRIP_GTK_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/gtk/tabs/tab_strip_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698