Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 371933003: Disable another WebView fullscreen video test until we land fullscreen IPC changes (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable another WebView fullscreen video test until we land fullscreen IPC changes there are 2 changes needs to be submitted before we reenable the tests: 1. https://codereview.chromium.org/290643005/ and 2. https://codereview.chromium.org/292573004/ the blink change will break all the tests, so we need to reenable the test after the chromium change lands BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
qinmin
PTAL
6 years, 5 months ago (2014-07-07 17:47:30 UTC) #1
boliu
lgtm you sure you got them all this time?
6 years, 5 months ago (2014-07-07 17:48:35 UTC) #2
qinmin
On 2014/07/07 17:48:35, boliu wrote: > lgtm > > you sure you got them all ...
6 years, 5 months ago (2014-07-07 19:06:06 UTC) #3
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-07 19:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/371933003/1
6 years, 5 months ago (2014-07-07 19:07:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 21:31:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 21:38:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/40838)
6 years, 5 months ago (2014-07-07 21:38:14 UTC) #8
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-07 21:50:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/371933003/1
6 years, 5 months ago (2014-07-07 21:51:36 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 00:47:21 UTC) #11
commit-bot: I haz the power
Change committed as 281627
6 years, 5 months ago (2014-07-08 01:50:05 UTC) #12
qinmin
6 years, 5 months ago (2014-07-09 16:32:50 UTC) #13
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/382583002/ by qinmin@chromium.org.

The reason for reverting is: revert this as all related CLs are committed.

Powered by Google App Engine
This is Rietveld 408576698