Chromium Code Reviews| Index: chrome/browser/content_settings/permission_bubble_request_impl.h |
| diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.h b/chrome/browser/content_settings/permission_bubble_request_impl.h |
| index fe73c64cdf3548e24d9d023c663e287fd435a7bb..2519552c3bd5014ea988f27582435c8aee72636e 100644 |
| --- a/chrome/browser/content_settings/permission_bubble_request_impl.h |
| +++ b/chrome/browser/content_settings/permission_bubble_request_impl.h |
| @@ -41,11 +41,15 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest { |
| // TODO(miguelg) Change this method to GetOrigin() |
| virtual GURL GetRequestingHostname() const OVERRIDE; |
| + |
| + // Remember to call RegisterActionTaken fro these methods if you are |
|
Bernhard Bauer
2014/07/14 15:22:15
Nit: "for"
Miguel Garcia
2014/07/14 16:57:50
Done.
|
| + // overriding them. |
| virtual void PermissionGranted() OVERRIDE; |
| virtual void PermissionDenied() OVERRIDE; |
| virtual void Cancelled() OVERRIDE; |
| virtual void RequestFinished() OVERRIDE; |
| + void RegisterActionTaken() {action_taken_ = true; } |
|
Bernhard Bauer
2014/07/14 15:22:15
Nit: space after opening brace.
Also, please add
Miguel Garcia
2014/07/14 16:57:50
Done.
|
| private: |
| GURL request_origin_; |
| bool user_gesture_; |
| @@ -59,6 +63,7 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest { |
| // the caller. |
| const base::Closure delete_callback_; |
| bool is_finished_; |
| + bool action_taken_; |
| DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl); |
| }; |