Add UMA for the new generic permisison class

chrome/browser/content_settings/permission_bubble_request_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
 
 #include "base/callback.h"
 #include "chrome/browser/content_settings/permission_request_id.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
@@ skipping 23 matching lines @@
   virtual ~PermissionBubbleRequestImpl();
 
   // PermissionBubbleRequest:
   virtual int GetIconID() const OVERRIDE;
   virtual base::string16 GetMessageText() const OVERRIDE;
   virtual base::string16 GetMessageTextFragment() const OVERRIDE;
   virtual bool HasUserGesture() const OVERRIDE;
 
   // TODO(miguelg) Change this method to GetOrigin()
   virtual GURL GetRequestingHostname() const OVERRIDE;
+
+  // Remember to call RegisterActionTaken fro these methods if you are

[Bernhard Bauer, 2014/07/14 15:22:15]

Nit: "for"

[Miguel Garcia, 2014/07/14 16:57:50]

Done.

+  // overriding them.
   virtual void PermissionGranted() OVERRIDE;
   virtual void PermissionDenied() OVERRIDE;
   virtual void Cancelled() OVERRIDE;
   virtual void RequestFinished() OVERRIDE;
 
+  void RegisterActionTaken() {action_taken_ = true; }

[Bernhard Bauer, 2014/07/14 15:22:15]

Nit: space after opening brace.

Also, please add an empty line back in here.

Also, you could make this protected if it's just for subclasses to call.

[Miguel Garcia, 2014/07/14 16:57:50]

Done.

  private:
   GURL request_origin_;
   bool user_gesture_;
   ContentSettingsType type_;
   std::string display_languages_;
 
   // Called once a decision is made about the permission.
   const PermissionDecidedCallback permission_decided_callback_;
 
   // Called when the bubble is no longer in use so it can be deleted by
   // the caller.
   const base::Closure delete_callback_;
   bool is_finished_;
+  bool action_taken_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_