Fix optional neon support

Fix optional neon support

On Android, we detect neon support at runtime and switch implementations
based on that. This requires that some parts of skia are compiled with
-mfpu=neon.

To support this, the -mfpu flag is moved out of the 'compiler' config
and into its own config. A target can then remove this config and supply
its own -mfpu flag (without having to duplicate all the other stuff in
the 'compiler' config).

BUG=359249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286038

[cjhopman, 2014-07-07 22:44:08]

brettw: *

[cjhopman, 2014-07-11 21:02:24]

ping

[brettw, 2014-07-14 18:25:39]

lgtm

[cjhopman, 2014-07-14 20:11:48]

thakis: for skia/ OWNERS

[Nico, 2014-07-16 19:48:17]

lgtm since the gyp file does this too, but things starting with __ are reserved
for the compiler and shouldn't be defined by user code. Can you maybe check who
added that in gyp and ask them why they made this define start with __?

[cjhopman, 2014-07-28 20:52:16]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-07-28 20:53:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/371853007/60001

[commit-bot: I haz the power, 2014-07-28 22:10:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-07-29 00:21:03]

Change committed as 286038

[cjhopman, 2014-07-31 22:18:07]

On 2014/07/16 19:48:17, Nico (away) wrote:
> lgtm since the gyp file does this too, but things starting with __ are
reserved
> for the compiler and shouldn't be defined by user code. Can you maybe check
who
> added that in gyp and ask them why they made this define start with __?

Just a quick followup note on this, skia is fixing the use of reserved names:
https://codereview.chromium.org/430253002

[Nico, 2014-07-31 22:31:52]

Great, thanks!


On Thu, Jul 31, 2014 at 3:18 PM, <cjhopman@chromium.org> wrote:

> On 2014/07/16 19:48:17, Nico (away) wrote:
>
>> lgtm since the gyp file does this too, but things starting with __ are
>>
> reserved
>
>> for the compiler and shouldn't be defined by user code. Can you maybe
>> check
>>
> who
>
>> added that in gyp and ask them why they made this define start with __?
>>
>
> Just a quick followup note on this, skia is fixing the use of reserved
> names:
> https://codereview.chromium.org/430253002
>
> https://codereview.chromium.org/371853007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.