Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 430253002: Update NEON compiler flags for Skia to use the SK_ prefix. (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update NEON compiler flags for Skia to use the SK_ prefix. The old defines will be left in place until the next Skia DEPS roll. After that roll Skia will be switched to using the SK_ prefixed defines and the old reserved (i.e. __ARM*) defines can be removed. BUG=skia:2785 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286901

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M skia/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 chunks +0 lines, -22 lines 2 comments Download

Messages

Total messages: 18 (0 generated)
djsollen
6 years, 4 months ago (2014-07-31 16:02:28 UTC) #1
djsollen
https://codereview.chromium.org/430253002/diff/1/skia/skia_library_opts.gyp File skia/skia_library_opts.gyp (left): https://codereview.chromium.org/430253002/diff/1/skia/skia_library_opts.gyp#oldcode68 skia/skia_library_opts.gyp:68: [ 'arm_version >= 7 and arm_neon == 1', { ...
6 years, 4 months ago (2014-07-31 16:05:54 UTC) #2
mtklein
lgtm
6 years, 4 months ago (2014-07-31 16:08:34 UTC) #3
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-07-31 16:15:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djsollen@google.com/430253002/1
6 years, 4 months ago (2014-07-31 16:17:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 16:17:17 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 16:17:18 UTC) #7
mtklein_C
lgtm
6 years, 4 months ago (2014-07-31 16:17:51 UTC) #8
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-07-31 16:18:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djsollen@google.com/430253002/1
6 years, 4 months ago (2014-07-31 16:20:19 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 16:20:21 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 16:20:22 UTC) #12
djsollen
6 years, 4 months ago (2014-07-31 16:23:15 UTC) #13
bungeman-chromium
lgtm
6 years, 4 months ago (2014-07-31 16:24:24 UTC) #14
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-07-31 16:24:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djsollen@google.com/430253002/1
6 years, 4 months ago (2014-07-31 16:26:01 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 20:17:50 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 22:05:43 UTC) #18
Message was sent while issue was closed.
Change committed as 286901

Powered by Google App Engine
This is Rietveld 408576698