Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 371413004: Fix for input/datalist failure when datalist is created outside document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Using didNotifySubtreeInsertionsToDocument Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 9078c6e92d0555b5ccb433fdd73498f4ec333548..1e371767cbe90be9dddca634519ce910bddf26c9 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -1438,7 +1438,7 @@ Node::InsertionNotificationRequest HTMLInputElement::insertedInto(ContainerNode*
if (insertionPoint->inDocument() && !form())
addToRadioButtonGroup();
resetListAttributeTargetObserver();
- return InsertionDone;
+ return InsertionShouldCallDidNotifySubtreeInsertions;
}
void HTMLInputElement::removedFrom(ContainerNode* insertionPoint)
@@ -1886,4 +1886,9 @@ bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St
return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue);
}
+void HTMLInputElement::didNotifySubtreeInsertionsToDocument()
+{
+ listAttributeTargetChanged();
+}
+
} // namespace
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698