Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 371413004: Fix for input/datalist failure when datalist is created outside document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Using didNotifySubtreeInsertionsToDocument Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1420 matching lines...) Expand 10 before | Expand all | Expand 10 after
1431 argv.append("input"); 1431 argv.append("input");
1432 argv.append(fastGetAttribute(typeAttr)); 1432 argv.append(fastGetAttribute(typeAttr));
1433 argv.append(fastGetAttribute(formactionAttr)); 1433 argv.append(fastGetAttribute(formactionAttr));
1434 activityLogger->logEvent("blinkAddElement", argv.size(), argv.data() ); 1434 activityLogger->logEvent("blinkAddElement", argv.size(), argv.data() );
1435 } 1435 }
1436 } 1436 }
1437 HTMLTextFormControlElement::insertedInto(insertionPoint); 1437 HTMLTextFormControlElement::insertedInto(insertionPoint);
1438 if (insertionPoint->inDocument() && !form()) 1438 if (insertionPoint->inDocument() && !form())
1439 addToRadioButtonGroup(); 1439 addToRadioButtonGroup();
1440 resetListAttributeTargetObserver(); 1440 resetListAttributeTargetObserver();
1441 return InsertionDone; 1441 return InsertionShouldCallDidNotifySubtreeInsertions;
1442 } 1442 }
1443 1443
1444 void HTMLInputElement::removedFrom(ContainerNode* insertionPoint) 1444 void HTMLInputElement::removedFrom(ContainerNode* insertionPoint)
1445 { 1445 {
1446 if (insertionPoint->inDocument() && !form()) 1446 if (insertionPoint->inDocument() && !form())
1447 removeFromRadioButtonGroup(); 1447 removeFromRadioButtonGroup();
1448 HTMLTextFormControlElement::removedFrom(insertionPoint); 1448 HTMLTextFormControlElement::removedFrom(insertionPoint);
1449 ASSERT(!inDocument()); 1449 ASSERT(!inDocument());
1450 resetListAttributeTargetObserver(); 1450 resetListAttributeTargetObserver();
1451 } 1451 }
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1879 { 1879 {
1880 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1880 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1881 } 1881 }
1882 #endif 1882 #endif
1883 1883
1884 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1884 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1885 { 1885 {
1886 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1886 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1887 } 1887 }
1888 1888
1889 void HTMLInputElement::didNotifySubtreeInsertionsToDocument()
1890 {
1891 listAttributeTargetChanged();
1892 }
1893
1889 } // namespace 1894 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698