Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 371363002: Query objects should not be shared between contexts (Closed)

Created:
6 years, 5 months ago by hj.r.chung
Modified:
6 years, 5 months ago
Reviewers:
bajones, no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Query objects should not be shared between contexts glQuery objects are not sharable, so managing IDs for each client locally in GLES2Implementation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282292

Patch Set 1 #

Total comments: 12

Patch Set 2 : new patch with comments applied #

Total comments: 2

Patch Set 3 : fixed nit #

Patch Set 4 : fix error #

Patch Set 5 : reverted DCHECK -> DCHECK_NE change to avoid error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -30 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 3 chunks +16 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 7 chunks +11 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 8 chunks +24 lines, -21 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
hj.r.chung
PTAL!
6 years, 5 months ago (2014-07-08 12:26:34 UTC) #1
piman
+sievers -piman
6 years, 5 months ago (2014-07-08 17:37:05 UTC) #2
no sievers
https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py#newcode4063 gpu/command_buffer/build_gles2_cmd_buffer.py:4063: args['alloc_code'] = alloc_code what's this line needed for? https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/client/gles2_implementation.cc ...
6 years, 5 months ago (2014-07-08 22:54:04 UTC) #3
hj.r.chung
updated patch and left a couple of comments! https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py#newcode4063 gpu/command_buffer/build_gles2_cmd_buffer.py:4063: args['alloc_code'] ...
6 years, 5 months ago (2014-07-09 05:26:46 UTC) #4
no sievers
lgtm https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/client/gles2_implementation.cc#newcode327 gpu/command_buffer/client/gles2_implementation.cc:327: return share_group_->GetIdHandler(namespace_id); On 2014/07/09 05:26:46, hj.r.chung wrote: > ...
6 years, 5 months ago (2014-07-09 17:50:49 UTC) #5
hj.r.chung
On 2014/07/09 17:50:49, sievers wrote: > lgtm > > https://codereview.chromium.org/371363002/diff/1/gpu/command_buffer/client/gles2_implementation.cc > File gpu/command_buffer/client/gles2_implementation.cc (right): > ...
6 years, 5 months ago (2014-07-10 01:19:04 UTC) #6
hj.r.chung
https://codereview.chromium.org/371363002/diff/20001/gpu/command_buffer/client/gles2_implementation.cc File gpu/command_buffer/client/gles2_implementation.cc (right): https://codereview.chromium.org/371363002/diff/20001/gpu/command_buffer/client/gles2_implementation.cc#newcode331 gpu/command_buffer/client/gles2_implementation.cc:331: DCHECK(namespace_id == id_namespaces::kQueries); On 2014/07/09 17:50:48, sievers wrote: > ...
6 years, 5 months ago (2014-07-10 01:19:28 UTC) #7
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-10 02:46:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/371363002/40001
6 years, 5 months ago (2014-07-10 02:48:04 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 03:33:08 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 03:38:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/159722) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/50139) mac_chromium_rel ...
6 years, 5 months ago (2014-07-10 03:38:52 UTC) #12
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-10 04:21:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/371363002/60001
6 years, 5 months ago (2014-07-10 04:23:24 UTC) #14
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-10 04:44:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/371363002/80001
6 years, 5 months ago (2014-07-10 04:44:47 UTC) #16
commit-bot: I haz the power
Change committed as 282292
6 years, 5 months ago (2014-07-10 08:26:15 UTC) #17
ccameron
6 years, 5 months ago (2014-07-10 19:09:15 UTC) #18
Message was sent while issue was closed.
On 2014/07/10 08:26:15, I haz the power (commit-bot) wrote:
> Change committed as 282292

I've been seeing lots of failures of the WebGL conformance test
conformance_context_context_release_with_workers since this change. The failures
are intermittent, so it's not clear that it is this change, but it's the only
recent GPU/WebGL related change. I may revert to see if it fixes the problem.

Powered by Google App Engine
This is Rietveld 408576698