Issue 371113002: Fixes for re-enabling more MSVC level 4 warnings: components/ edition

Issue 371113002: Fixes for re-enabling more MSVC level 4 warnings: components/ edition (Closed)

Created:
6 years, 5 months ago by Peter Kasting

Modified:
6 years, 5 months ago

Reviewers:
blundell

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes for re-enabling more MSVC level 4 warnings: components/ edition This contains fixes for the following sorts of issues: * Signedness mismatch * Assignment inside conditional * Possibly-uninitialized local variable BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281893

Patch Set 1 #

Total comments: 1

Patch Set 2 : Attempt to fix compile failure #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -22 lines)			Patch
M	components/domain_reliability/scheduler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_form_manager.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	components/search_engines/template_url.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/search_engines/template_url_prepopulate_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/translate/core/browser/translate_infobar_delegate.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	components/translate/core/browser/translate_ui_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/translate/core/browser/translate_ui_delegate.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	components/url_matcher/substring_set_matcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/wifi/wifi_service_win.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

https://codereview.chromium.org/371113002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/371113002/diff/1/components/search_engines/template_url.cc#newcode230 components/search_engines/template_url.cc:230: index_in_owner_(0), It doesn't actually matter what this is set ...

6 years, 5 months ago (2014-07-07 21:07:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/371113002/20001

6 years, 5 months ago (2014-07-08 19:33:55 UTC) #4

Message was sent while issue was closed.

Change committed as 281893

Expand Messages | Collapse Messages