components/password_manager/core/browser/password_form_manager.cc - Issue 371113002: Fixes for re-enabling more MSVC level 4 warnings: components/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 371113002: Fixes for re-enabling more MSVC level 4 warnings: components/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Attempt to fix compile failure Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 1ddefdebcd70ece716647816ff4d6dd0e343c4b4..42a5681772ba44c4a007409a50522063f03b4763 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -629,8 +629,9 @@ void PasswordFormManager::CheckForAccountCreationForm(

if (!pending.form_data.fields.empty() &&

pending_structure.FormSignature() !=

observed_structure.FormSignature()) {

- autofill::AutofillManager* autofill_manager;

- if ((autofill_manager = driver_->GetAutofillManager())) {

+ autofill::AutofillManager* autofill_manager =

+ driver_->GetAutofillManager();

+ if (autofill_manager) {

// Note that this doesn't guarantee that the upload succeeded, only that

// |pending.form_data| is considered uploadable.

bool success =