Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 371060: Mac: Make download items less annoying by handling clicks more correctly. (Closed)

Created:
11 years, 1 month ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make download items less annoying by handling clicks more correctly. BUG=21916 TEST=Download two files, click first downoad item, click second download item. Both should open, no context menu should appear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31432

Patch Set 1 #

Patch Set 2 : add comment, fix layout-o #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/browser/cocoa/download_item_cell.mm View 1 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
I can imagine that more of our tracking areas need this fix. Maybe we should ...
11 years, 1 month ago (2009-11-08 21:46:37 UTC) #1
pink (ping after 24hrs)
I don't understand why the tracking area affects how the mouse click is processed.
11 years, 1 month ago (2009-11-09 15:25:49 UTC) #2
Nico
On 2009/11/09 15:25:49, pink wrote: > I don't understand why the tracking area affects how ...
11 years, 1 month ago (2009-11-09 15:57:26 UTC) #3
pink (ping after 24hrs)
LGTM Please add a comment to that effect with the tracking rect so that it's ...
11 years, 1 month ago (2009-11-09 16:01:28 UTC) #4
Nico
11 years, 1 month ago (2009-11-09 16:23:49 UTC) #5
Thanks for the review, submitting.

> Please add a comment to that effect with the tracking rect so that it's more
> clear about its impact.

Done.

Powered by Google App Engine
This is Rietveld 408576698