Mac: Make download items less annoying by handling clicks more correctly.

chrome/browser/cocoa/download_item_cell.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/download_item_cell.h"
 
 #include "app/gfx/canvas_paint.h"
 #include "app/gfx/text_elider.h"
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
@@ skipping 178 matching lines @@
   if (trackingAreaButton_) {
     [[self controlView] removeTrackingArea:trackingAreaButton_.get()];
       trackingAreaButton_.reset(nil);
   }
   if (trackingAreaDropdown_) {
     [[self controlView] removeTrackingArea:trackingAreaDropdown_.get()];
       trackingAreaDropdown_.reset(nil);
   }
 
   // Use two distinct tracking rects for left and right parts.
+  // The tracking areas are also used to decide how to handle clicks. They must
+  // always be active, so the click is handled correctly when a download item
+  // is clicked while chrome is not the active app ( http://crbug.com/21916 ).
   NSRect bounds = [[self controlView] bounds];
   NSRect buttonRect, dropdownRect;
   NSDivideRect(bounds, &dropdownRect, &buttonRect,
       kDropdownAreaWidth, NSMaxXEdge);
 
-    trackingAreaButton_.reset([[NSTrackingArea alloc]
-                    initWithRect:buttonRect
-                         options:(NSTrackingMouseEnteredAndExited |
-                                  NSTrackingActiveInActiveApp)
-                           owner:self
-                      userInfo:nil]);
+  trackingAreaButton_.reset([[NSTrackingArea alloc]
+                  initWithRect:buttonRect
+                       options:(NSTrackingMouseEnteredAndExited |
+                                NSTrackingActiveAlways)
+                         owner:self
+                    userInfo:nil]);
   [[self controlView] addTrackingArea:trackingAreaButton_.get()];
 
-    trackingAreaDropdown_.reset([[NSTrackingArea alloc]
-                    initWithRect:dropdownRect
-                         options:(NSTrackingMouseEnteredAndExited |
-                                  NSTrackingActiveInActiveApp)
-                           owner:self
-                      userInfo:nil]);
+  trackingAreaDropdown_.reset([[NSTrackingArea alloc]
+                  initWithRect:dropdownRect
+                       options:(NSTrackingMouseEnteredAndExited |
+                                NSTrackingActiveAlways)
+                         owner:self
+                    userInfo:nil]);
   [[self controlView] addTrackingArea:trackingAreaDropdown_.get()];
 }
 
 - (void)setShowsBorderOnlyWhileMouseInside:(BOOL)showOnly {
   // Override to make sure it doesn't do anything if it's called accidentally.
 }
 
 - (void)mouseEntered:(NSEvent*)theEvent {
   mouseInsideCount_++;
   if ([theEvent trackingArea] == trackingAreaButton_.get())
@@ skipping 324 matching lines @@
   }
   return self;
 }
 
 - (void)setCurrentProgress:(NSAnimationProgress)progress {
   [super setCurrentProgress:progress];
   [cell_ animation:self progressed:progress];
 }
 
 @end