Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 371054: Remove flaky label for one test.... (Closed)

Created:
11 years, 1 month ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigate When I started looking into the test flakiness, it turns out it hasn't failed in 3 weeks, according to Phajdan's logs, so I am removing the Flaky label. BUG=16447 TEST=This is a test change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/views/find_bar_host_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 1 month ago (2009-11-07 20:02:26 UTC) #1
Finnur
11 years, 1 month ago (2009-11-08 03:08:58 UTC) #2
Thank you for that, Pavel.

On Sat, Nov 7, 2009 at 12:32, <phajdan.jr@chromium.org> wrote:

> LGTM.
>
> I changed the commit message a little to include the test name.
>
>
> http://codereview.chromium.org/371054
>

Powered by Google App Engine
This is Rietveld 408576698