Issue 371054: Remove flaky label for one test....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371054: Remove flaky label for one test.... (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigate When I started looking into the test flakiness, it turns out it hasn't failed in 3 weeks, according to Phajdan's logs, so I am removing the Flaky label. BUG=16447 TEST=This is a test change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31399

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/views/find_bar_host_browsertest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

11 years, 1 month ago (2009-11-08 03:08:58 UTC) #2

Thank you for that, Pavel.

On Sat, Nov 7, 2009 at 12:32, <phajdan.jr@chromium.org> wrote:

> LGTM.
>
> I changed the commit message a little to include the test name.
>
>
> http://codereview.chromium.org/371054
>

Expand Messages | Collapse Messages