Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: chrome/browser/views/find_bar_host_browsertest.cc

Issue 371054: Remove flaky label for one test.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/keyboard_codes.h" 5 #include "base/keyboard_codes.h"
6 #include "base/message_loop.h" 6 #include "base/message_loop.h"
7 #include "chrome/browser/browser.h" 7 #include "chrome/browser/browser.h"
8 #include "chrome/browser/browser_window.h" 8 #include "chrome/browser/browser_window.h"
9 #include "chrome/browser/find_bar_controller.h" 9 #include "chrome/browser/find_bar_controller.h"
10 #include "chrome/browser/find_notification_details.h" 10 #include "chrome/browser/find_notification_details.h"
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 ASSERT_TRUE(NULL != tab_contents); 449 ASSERT_TRUE(NULL != tab_contents);
450 450
451 // Search for a text that exists within a link on the page. 451 // Search for a text that exists within a link on the page.
452 int ordinal = 0; 452 int ordinal = 0;
453 EXPECT_EQ(2, ui_test_utils::FindInPage(tab_contents, L"html ", 453 EXPECT_EQ(2, ui_test_utils::FindInPage(tab_contents, L"html ",
454 kFwd, kIgnoreCase, &ordinal)); 454 kFwd, kIgnoreCase, &ordinal));
455 EXPECT_EQ(1, ordinal); 455 EXPECT_EQ(1, ordinal);
456 } 456 }
457 457
458 // Make sure Find box disappears on Navigate but not on Refresh. 458 // Make sure Find box disappears on Navigate but not on Refresh.
459 // Flaky, see http://crbug.com/16447. 459 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate) {
460 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
461 FLAKY_FindDisappearOnNavigate) {
462 HTTPTestServer* server = StartHTTPServer(); 460 HTTPTestServer* server = StartHTTPServer();
463 461
464 // First we navigate to our special focus tracking page. 462 // First we navigate to our special focus tracking page.
465 GURL url = server->TestServerPageW(kSimplePage); 463 GURL url = server->TestServerPageW(kSimplePage);
466 GURL url2 = server->TestServerPageW(kFramePage); 464 GURL url2 = server->TestServerPageW(kFramePage);
467 ui_test_utils::NavigateToURL(browser(), url); 465 ui_test_utils::NavigateToURL(browser(), url);
468 466
469 // Open the Find window with animations disabled. 467 // Open the Find window with animations disabled.
470 FindBarHost::disable_animations_during_testing_ = true; 468 FindBarHost::disable_animations_during_testing_ = true;
471 browser()->ShowFindBar(); 469 browser()->ShowFindBar();
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 // backspace, but that's been proven flaky in the past, so we go straight to 680 // backspace, but that's been proven flaky in the past, so we go straight to
683 // tab_contents. 681 // tab_contents.
684 TabContents* tab_contents = browser()->GetSelectedTabContents(); 682 TabContents* tab_contents = browser()->GetSelectedTabContents();
685 // Stop the (non-existing) find operation, and clear the selection (which 683 // Stop the (non-existing) find operation, and clear the selection (which
686 // signals the UI is still active). 684 // signals the UI is still active).
687 tab_contents->StopFinding(true); 685 tab_contents->StopFinding(true);
688 // Make sure the Find UI flag hasn't been cleared, it must be so that the UI 686 // Make sure the Find UI flag hasn't been cleared, it must be so that the UI
689 // still responds to browser window resizing. 687 // still responds to browser window resizing.
690 ASSERT_TRUE(tab_contents->find_ui_active()); 688 ASSERT_TRUE(tab_contents->find_ui_active());
691 } 689 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698