fpdfsdk/include/fsdk_define.h - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fsdk_define.h

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/fsdk_define.h

diff --git a/fpdfsdk/include/fsdk_define.h b/fpdfsdk/include/fsdk_define.h

index 2bf4721c0d43564db9880b82f4c55c1d47928b92..433ff4c1844e1258467abc72a0e36f201fb306cf 100644

--- a/fpdfsdk/include/fsdk_define.h

+++ b/fpdfsdk/include/fsdk_define.h

@@ -101,7 +101,7 @@ typedef unsigned int FX_UINT;

#include "fpdfview.h"

-class CPDF_CustomAccess : public IFX_FileRead, public CFX_Object

+class CPDF_CustomAccess FX_FINAL : public IFX_FileRead, public CFX_Object

{

public:

CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess);

« no previous file with comments | « core/src/fxge/apple/apple_int.h ('k') | fpdfsdk/include/fsdk_mgr.h » ('j') | no next file with comments »