core/src/fxge/apple/apple_int.h - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/apple/apple_int.h

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/apple/apple_int.h

diff --git a/core/src/fxge/apple/apple_int.h b/core/src/fxge/apple/apple_int.h

index 42d63628f24ef96a335309b88cfaf28189afdf3e..a8fbe2fbaaaa14485c38be1654d1c5ff0f7b754b 100644

--- a/core/src/fxge/apple/apple_int.h

+++ b/core/src/fxge/apple/apple_int.h

@@ -185,7 +185,7 @@ protected:

FX_INT32 _horzSize;

FX_INT32 _vertSize;

};

-class CFX_FontProvider : public IFX_FileRead

+class CFX_FontProvider FX_FINAL : public IFX_FileRead

{

public:

virtual void Release()

« no previous file with comments | « core/src/fxcrt/fx_arabic.h ('k') | fpdfsdk/include/fsdk_define.h » ('j') | no next file with comments »