fpdfsdk/src/fpdfview.cpp - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfview.cpp

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fpdfview.cpp

diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp

index a5ba796158705184300e27a699a48ce64c4b02f6..6c72b8190a4ad1ab1d36fd48e209045179896fbc 100644

--- a/fpdfsdk/src/fpdfview.cpp

+++ b/fpdfsdk/src/fpdfview.cpp

@@ -289,7 +289,7 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadDocument(FPDF_STRING file_path, FPDF_BY

extern void CheckUnSupportError(CPDF_Document * pDoc, FX_DWORD err_code);

-class CMemFile: public IFX_FileRead, public CFX_Object

+class CMemFile FX_FINAL: public IFX_FileRead, public CFX_Object

{

public:

CMemFile(FX_BYTE* pBuf, FX_FILESIZE size):m_pBuf(pBuf),m_size(size) {}

« fpdfsdk/src/fpdfeditpage.cpp ('K') | « fpdfsdk/src/fpdfsave.cpp ('k') | no next file » | no next file with comments »